(closes #30) add basic formatting and linting pipeline#37
Open
qdbp wants to merge 1 commit intoxjdr-alt:mainfrom
Open
(closes #30) add basic formatting and linting pipeline#37qdbp wants to merge 1 commit intoxjdr-alt:mainfrom
qdbp wants to merge 1 commit intoxjdr-alt:mainfrom
Conversation
|
nit: add "closes #30" in your PR description so it gets linked |
qdbp
changed the title
qdbp
force-pushed
the
gh30-implement-basic-code-quality-gate
branch
from
7ad7a8b to
c7eb4ab
Compare
|
Thoughts on using an opinionated code formatter like |
Contributor
Author
|
my underestanding is that I was surprised to see that it supports custom indents (maybe they changed that), tbh my preference is to just use an indent of 4 -- but I don't want to just steamroll everyone on a whim either. I expect the BDFL will dictate |
qdbp
force-pushed
the
gh30-implement-basic-code-quality-gate
branch
from
c7eb4ab to
093736f
Compare
qdbp
force-pushed
the
gh30-implement-basic-code-quality-gate
branch
from
093736f to
0b997a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(closes #30)
this is my first naive stab at a code quality gate
I think this is quite a high priority since we're already at files with mixed indentations. barring this we're going to have a tough time keeping diff surface area low, which will make reviews painful.
any specifics (i.e. line length) obviously open for discussions